add 2fa backup codes app by ChristophWurst · Pull Request #1171 · nextcloud/server

ChristophWurst · 2016-08-29T17:25:29Z

integrates https://github.com/ChristophWurst/twofactor_backupcodes and fixes #1108

App is always enabled, so users can create backup codes even before an admin randomly enables/enforces a 2FA provider
Does not enforce 2FA is this app is the only active 2FA provider
Does not show up in the list of selectable 2FA providers
Adds a "Use backup code" link underneath the 2FA selection page and 2FA challenge page

TODO:

Unit/integration tests for the twofactor_backupcodes app
Fix/add tests for the changed server classes

@nextcloud/designers any idea how we could make the settings dialog prettier? See the screenshots in https://github.com/ChristophWurst/twofactor_backupcodes for how it looks now.

mention-bot · 2016-08-29T17:25:31Z

@ChristophWurst, thanks for your PR! By analyzing the annotation information on this pull request, we identified @bantu, @icewind1991 and @DeepDiver1975 to be potential reviewers

ChristophWurst · 2016-08-29T17:28:31Z

 </div>
 <a class="two-factor-cancel" <?php print_unescaped($_['logout_attribute']); ?>><?php p($l->t('Cancel log in')) ?></a>
+<?php if (!is_null($_['backupProvider'])): ?>
+<a class="two-factor-cancel" href="<?php p(\OC::$server->getURLGenerator()->linkToRoute('core.TwoFactorChallenge.showChallenge',


TODO: rename class

ChristophWurst · 2016-09-02T10:34:13Z

/usr/local/bin/phpunit --configuration phpunit-autotest.xml --exclude-group DB --log-junit autotest-results-sqlite.xml  
PHP Parse error:  syntax error, unexpected 'class' (T_CLASS), expecting identifier (T_STRING) or variable (T_VARIABLE) or '{' or '$' in /drone/src/github.com/nextcloud/server/tests/Core/Command/Config/App/DeleteConfigTest.php on line 46
[info] build failed (exit code 255)

unrelated?

ChristophWurst · 2016-09-02T10:40:49Z

@rullzer @LukasReschke @nicohauger @zkwoob @Alphakilo @jancborchardt @Mar1u5 review and test this please.

The personal settings dialog definitely needs some UI/UX enhancements, that I'd like to postpone to follow-up PRs as this one is already rather big.

ChristophWurst · 2016-09-02T10:41:43Z

Does PHPUnit automatically find the test of the newly added app or do I have to register them somewhere?

MorrisJobke · 2016-09-02T11:36:35Z

$ NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh sqlite
Using PHP executable /usr/bin/php
Parsing all files in lib/public for the presence of @since or @deprecated on each method...

Using database oc_autotest
Setup environment for sqlite testing on local storage ...
Installing ....
Nextcloud is not installed - only a limited number of commands are available
creating sqlite db
Nextcloud was successfully installed
Testing with sqlite ...
No coverage
/usr/local/bin/phpunit --configuration phpunit-autotest.xml --group DB --log-junit autotest-results-sqlite.xml  
PHPUnit 4.8.24 by Sebastian Bergmann and contributors.

Runtime:    PHP 5.6.22-0+deb8u1
Configuration:  /drone/src/github.com/nextcloud/server/tests/phpunit-autotest.xml
Warning:    Deprecated configuration setting "strict" used

........S....................................................   61 / 4240 (  1%)
PHP Fatal error:  Call to a member function getUpdater() on null in /drone/src/github.com/nextcloud/server/lib/private/Files/View.php on line 695
[info] build failed (exit code 255)

ChristophWurst · 2016-09-02T11:46:55Z

let me try to reproduce the failing tests locally…

ChristophWurst · 2016-09-02T11:49:50Z

@MorrisJobke what are the requirements/preconditions to run all tests locally? I get Tests: 4716, Assertions: 12160, Errors: 1359, Failures: 13, Skipped: 286. :-(

MorrisJobke · 2016-09-02T12:30:11Z

@MorrisJobke what are the requirements/preconditions to run all tests locally?

drone exec

(see http://readme.drone.io/devs/cli/)

Best is also to remove the running tests from .drone.yml this speeds up the test execution ;)

ChristophWurst · 2016-09-02T12:40:12Z

stack trace:

Call to a member function getUpdater() on null in /server/lib/private/Files/View.php on line 696
#0  OC\Files\View->unlink() called at [/server/lib/private/Cache/File.php:146]
#1  OC\Cache\File->remove() called at [/server/tests/lib/Cache/FileCacheTest.php:91]
#2  Test\Cache\FileCacheTest->tearDown() called at [phar:///usr/local/bin/phpunit/phpunit/Framework/TestCase.php:805]
#3  PHPUnit_Framework_TestCase->runBare() called at [phar:///usr/local/bin/phpunit/phpunit/Framework/TestResult.php:612]
#4  PHPUnit_Framework_TestResult->run() called at [phar:///usr/local/bin/phpunit/phpunit/Framework/TestCase.php:724]
#5  PHPUnit_Framework_TestCase->run() called at [phar:///usr/local/bin/phpunit/phpunit/Framework/TestSuite.php:747]
#6  PHPUnit_Framework_TestSuite->run() called at [phar:///usr/local/bin/phpunit/phpunit/Framework/TestSuite.php:747]
#7  PHPUnit_Framework_TestSuite->run() called at [phar:///usr/local/bin/phpunit/phpunit/TextUI/TestRunner.php:440]
#8  PHPUnit_TextUI_TestRunner->doRun() called at [phar:///usr/local/bin/phpunit/phpunit/TextUI/Command.php:149]
#9  PHPUnit_TextUI_Command->run() called at [phar:///usr/local/bin/phpunit/phpunit/TextUI/Command.php:100]
#10 PHPUnit_TextUI_Command::main() called at [/usr/local/bin/phpunit:548]

* add backup codes app unit tests * add integration tests for the backup codes app

…r tests

rullzer · 2016-09-05T07:28:11Z

Some dark magic. Seems something was not cleaned up properly or so which caused the whole thing to break down.

CI seems a lot happier now ;)

ChristophWurst · 2016-09-05T07:35:00Z

Thank you very much @rullzer 🚀

rullzer · 2016-09-05T08:40:34Z

CI happy.
Tested in combination with TOTP and worked like a charm.
Code looks good! LGTM!

MariusBluem · 2016-09-05T10:16:36Z

Works 👍

nickvergessen · 2016-09-05T10:33:53Z

+	<licence>agpl</licence>
+	<author>Christoph Wurst</author>
+	<version>1.0.0</version>
+	<namespace>TwoFactor_BackupCodes</namespace>


Please, no underscores in PSR-4 Namespaces

ChristophWurst added enhancement 2. developing Work in progress labels Aug 29, 2016

ChristophWurst added this to the Nextcloud 11.0 milestone Aug 29, 2016

ChristophWurst force-pushed the 2fa-backup-codes branch from 2beb842 to 77dfd56 Compare August 29, 2016 17:26

ChristophWurst reviewed Aug 29, 2016
View reviewed changes

This was referenced Sep 1, 2016

Restoring access nextcloud/twofactor_totp#53

Closed

FR: Backup Codes nextcloud/twofactor_totp#54

Closed

ChristophWurst force-pushed the 2fa-backup-codes branch 2 times, most recently from db8d267 to 8a68d20 Compare September 2, 2016 09:53

ChristophWurst force-pushed the 2fa-backup-codes branch from 8a68d20 to 2037cf9 Compare September 2, 2016 10:36

ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 2, 2016

ChristophWurst force-pushed the 2fa-backup-codes branch from 4c79aa7 to 12a3ee8 Compare September 2, 2016 10:57

ChristophWurst assigned LukasReschke Sep 2, 2016

add 2fa backup codes app

8acb734

* add backup codes app unit tests * add integration tests for the backup codes app

increase core version number to trigger db ugprade and fix app manage…

ddb659d

…r tests

rullzer force-pushed the 2fa-backup-codes branch from 12a3ee8 to 0d4e304 Compare September 5, 2016 06:51

Fix AppTest and intergration test

581a83c

rullzer force-pushed the 2fa-backup-codes branch from 0d4e304 to 581a83c Compare September 5, 2016 07:43

MariusBluem merged commit f8eb7be into master Sep 5, 2016

MariusBluem deleted the 2fa-backup-codes branch September 5, 2016 10:17

nickvergessen reviewed Sep 5, 2016
View reviewed changes

This was referenced Sep 7, 2016

Improve backup codes UI/UX #1309

Closed

Possibility for the admin to show the QR Code nextcloud/twofactor_totp#58

Closed

This was referenced Oct 3, 2016

Do not use underscores in PSR4 namespaces of the backup codes app #1613

Merged

What if I lose my phone? nextcloud/twofactor_totp#63

Closed

ChristophWurst mentioned this pull request Nov 21, 2016

create 2FA documentation nextcloud/documentation#236

Merged

yesiamdollar mentioned this pull request Feb 6, 2024

[Snyk] Security upgrade nextcloud-vue-collections from 0.11.1 to 0.12.0 yesiamdollar/nextcloud-server#14

Open

0403350035 mentioned this pull request Apr 14, 2024

[Snyk] Fix for 1 vulnerabilities 0403350035/server#7

Open

Uh oh!

Uh oh!

Conversation

ChristophWurst commented Aug 29, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mention-bot commented Aug 29, 2016

Uh oh!

ChristophWurst Aug 29, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ChristophWurst commented Sep 2, 2016

Uh oh!

ChristophWurst commented Sep 2, 2016

Uh oh!

ChristophWurst commented Sep 2, 2016

Uh oh!

MorrisJobke commented Sep 2, 2016

Uh oh!

ChristophWurst commented Sep 2, 2016

Uh oh!

ChristophWurst commented Sep 2, 2016

Uh oh!

MorrisJobke commented Sep 2, 2016

Uh oh!

ChristophWurst commented Sep 2, 2016

Uh oh!

rullzer commented Sep 5, 2016

Uh oh!

ChristophWurst commented Sep 5, 2016

Uh oh!

rullzer commented Sep 5, 2016

Uh oh!

MariusBluem commented Sep 5, 2016

Uh oh!

nickvergessen Sep 5, 2016

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ChristophWurst commented Aug 29, 2016 •

edited

Loading

ChristophWurst Aug 29, 2016 •

edited

Loading